Snowbridge: Support bridging native ETH by alistair-singh · Pull Request #6855 · paritytech/polkadot-sdk

alistair-singh · 2024-12-12T08:50:09Z

Changes:

Use the 0x0000000000000000000000000000000000000000 token address as Native ETH.
Convert it to/from { parents: 2, interior: X1(GlobalConsensus(Ethereum{chain_id: 1})) } when encountered.

Onchain changes:
This will require a governance request to register native ETH (with the above location) in the foreign assets pallet and make it sufficient.

Related solidity changes: Snowfork/snowbridge#1354

TODO:

Emulated Tests

vgeddes · 2024-12-18T20:04:57Z

The approach looks good!

vgeddes · 2024-12-20T08:32:43Z

Will approve once you've implemented the emulated test that verifies the full BH->AH path.

yrong · 2024-12-23T09:50:38Z

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

+/// Tests the full cycle of eth transfers:
+/// - sending a token to AssetHub
+/// - returning the token to Ethereum
+#[test]
+fn send_eth_asset_from_asset_hub_to_ethereum_and_back() {


Is Rococo deprecated so we may need to add new features/tests to Westend instead?

Yeah agree, I did not want to change all our test boilerplate in this PR to keep it focused. But I think we need to in a separate PR.

yes, this test (and others) needs to move to westend - can be followup PR, but pls do it

Copied tests in this PR: #7108

yrong

+1

vgeddes · 2024-12-23T15:44:59Z

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

+		type RuntimeEvent = <AssetHubRococo as Chain>::RuntimeEvent;
+		type RuntimeOrigin = <AssetHubRococo as Chain>::RuntimeOrigin;
+
+		let _issued_event = RuntimeEvent::ForeignAssets(pallet_assets::Event::Issued {


why the the underscore prepended to the variable name?

The assert_expected_events! macro does not "use" the variable from the perspective of the compiler. I think the token is copied into the macro body, so it leaves this variable unused. Using underscore silences the warning.

vgeddes · 2024-12-23T15:45:20Z

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

+		)
+		.unwrap();
+
+		let _burned_event = RuntimeEvent::ForeignAssets(pallet_assets::Event::Burned {


ditto, why the underscore?

Commented above.

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

vgeddes · 2024-12-23T15:51:00Z

bridges/snowbridge/primitives/router/src/outbound/mod.rs

 				match inner_location.unpack() {
 					(0, [AccountKey20 { network, key }]) if self.network_matches(network) =>
 						Some((H160(*key), *amount)),
+					(0, []) => Some((H160([0; 20]), *amount)),


Add comment for this case explaining why what we are trying to do here, for example, UnlockNativeToken command supports unlocking ether if token address is NULL.

Address in 17d98b7.

Convert it to/from { parents: 2, interior: X1(GlobalConsensus(Ethereum{chain_id: 1})) } when encountered

Could we use location { parents: 2, interior: X2[GlobalConsensus(Ethereum{chain_id: 1}),AccountKey20 { network: None, key: H160::zero().into() }] } to represent Ether?

To be consistent with other ERC20 assets, then I would assume there is no need for this branch.

This is a good point. But I think using the base { parents: 2, interior: X1(GlobalConsensus(Ethereum{chain_id: 1})) } is more intuitive so I prefer the current version. But lets discuss @vgeddes

vgeddes · 2024-12-23T15:52:47Z

bridges/snowbridge/primitives/router/src/inbound/mod.rs

-			2,
-			[GlobalConsensus(network), AccountKey20 { network: None, key: token.into() }],
-		)
+		if token == H160([0; 20]) {


Add a comment here explaining that a token address of 0x00... is equivalent to native ether.

Address in 17d98b7.

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>

bkchr

Not a XCM expert, left one DQ otherwise it looks reasonable.

bridges/snowbridge/pallets/inbound-queue/fixtures/Cargo.toml

bridges/snowbridge/primitives/router/Cargo.toml

bkchr · 2025-01-07T12:55:13Z

bridges/snowbridge/primitives/router/src/inbound/mod.rs

+		// If the token is `0x0000000000000000000000000000000000000000` then return the location of
+		// native Ether.
+		if token == H160([0; 20]) {
+			Location::new(2, [GlobalConsensus(network)])


DQ: Don't we need to check here that network == Ethereum(chain_id: 1)?

I saw that too and checked if it needs validation, it doesn't: convert_token_address() is internal fn called by convert_register_token() or convert_send_token() which are converting Ethereum commands into XCM programs, somewhere above on the callstack the source was already validated as being Ethereum and the only thing that varies here is the Ethereum chain_id (testnet or prod).

Maybe for clarity and hardening this helper function should take only chain_id and hardcode Ethereum as network:

- fn convert_token_address(network: NetworkId, token: H160) -> Location { + fn convert_token_address(chain_id: u64, token: H160) -> Location {

Hey thanks for setting the label. So the chain_id comes directly from the message encoded on the solidity side, where it is taken from the on-chain variable block.chainid

Passed in here:

polkadot-sdk/bridges/snowbridge/primitives/router/src/inbound/mod.rs

Line 304 in 1059be7

chain_id: u64,

From message body here:

polkadot-sdk/bridges/snowbridge/primitives/router/src/inbound/mod.rs

Line 194 in 1059be7

V1(MessageV1 { chain_id, command: SendToken { token, destination, amount, fee } }) =>

Decoded here:

polkadot-sdk/bridges/snowbridge/pallets/inbound-queue/src/lib.rs

Lines 279 to 280 in 1059be7

let message = VersionedMessage::decode_all(&mut envelope.payload.as_ref())

.map_err(|_| Error::<T>::InvalidPayload)?;

Encoded in solidity here, taken directly from the block: https://github.com/Snowfork/snowbridge/blob/20a804669e0da59cff01b09588e16f1267d98862/contracts/src/SubstrateTypes.sol#L81

So it does not need to be validated explicitly. It will be validated implicitly by message verification through the light client.

paritytech-cmd-bot-polkadot-sdk · 2025-01-08T14:19:41Z

Created backport PR for stable2407:

[stable2407] Backport #6855 #7088 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6855-to-stable2407
git worktree add --checkout .worktree/backport-6855-to-stable2407 backport-6855-to-stable2407
cd .worktree/backport-6855-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 4059282fc7b6ec965cc22a9a0df5920a4f3a4101
git push --force-with-lease

paritytech-cmd-bot-polkadot-sdk · 2025-01-08T14:19:49Z

Created backport PR for stable2409:

[stable2409] Backport #6855 #7089 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6855-to-stable2409
git worktree add --checkout .worktree/backport-6855-to-stable2409 backport-6855-to-stable2409
cd .worktree/backport-6855-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 4059282fc7b6ec965cc22a9a0df5920a4f3a4101
git push --force-with-lease

acatangiu · 2025-01-08T14:19:49Z

hmm, any way to trigger the backport bot after the PR was merged? cc @EgorPopelyaev

L.E.: Nevermind, bot picked it up automatically 💪

Changes: 1. Use the 0x0000000000000000000000000000000000000000 token address as Native ETH. 2. Convert it to/from `{ parents: 2, interior: X1(GlobalConsensus(Ethereum{chain_id: 1})) }` when encountered. Onchain changes: This will require a governance request to register native ETH (with the above location) in the foreign assets pallet and make it sufficient. Related solidity changes: Snowfork/snowbridge#1354 TODO: - [x] Emulated Tests --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de> (cherry picked from commit 4059282)

paritytech-cmd-bot-polkadot-sdk · 2025-01-08T14:19:55Z

Successfully created backport PR for stable2412:

[stable2412] Backport #6855 #7090

aurexav · 2025-01-09T04:20:12Z

bridges/snowbridge/pallets/inbound-queue/fixtures/src/send_native_eth.rs

+use sp_core::U256;
+use sp_std::vec;
+
+pub fn make_send_native_eth_message() -> InboundQueueFixture {


This could be a const fn.

Backport #6855 into `stable2409` from alistair-singh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Backport #6855 into `stable2412` from alistair-singh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

* master: Snowbridge: Support bridging native ETH (#6855) adding warning when using default substrateWeight in production (#7046) release: unset SKIP_WASM_BUILD (#7074) fix typos (#7068) Fix defensive! macro to be used in umbrella crates (#7069) rewrite some flaky zombienet polkadot tests to zombienet-sdk (#6757) Implement NetworkRequest for litep2p (#7073) migrate pallet-node-authorization to use umbrella crate (#7040)

alistair-singh mentioned this pull request Dec 12, 2024

Support Native ETH in v1 Snowfork/snowbridge#1354

Merged

3 tasks

alistair-singh added 2 commits December 17, 2024 21:38

convert interpret as ETH for null address

41bed52

support native eth in outbound queue

dd51d23

alistair-singh force-pushed the alistair/support-eth branch from 7a76da6 to dd51d23 Compare December 17, 2024 19:39

alistair-singh changed the base branch from stable2409 to master December 17, 2024 19:39

alistair-singh added 4 commits December 17, 2024 21:49

add pr doc

e5a6eb7

fix pr doc

0d6fbd4

Merge branch 'master' into alistair/support-eth

f15c012

Merge branch 'master' into alistair/support-eth

d4d25d2

docs, comments and renames

7c838e5

alistair-singh added 3 commits December 20, 2024 18:00

add fixture data

a98d3e7

fix fixtures

f174719

add round trip test

e1a6f18

alistair-singh marked this pull request as ready for review December 21, 2024 21:50

Merge branch 'master' into alistair/support-eth

5b50f11

paritytech-review-bot bot requested a review from a team December 21, 2024 21:51

alistair-singh added 3 commits December 22, 2024 00:02

update prdoc and versions

e272391

cargo fmt

005e62c

Merge branch 'master' into alistair/support-eth

d499776

This comment was marked as spam.

Sign in to view

yrong reviewed Dec 23, 2024

View reviewed changes

yrong approved these changes Dec 23, 2024

View reviewed changes

vgeddes reviewed Dec 23, 2024

View reviewed changes

alistair-singh and others added 3 commits December 23, 2024 18:26

rename test

8799c23

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>

added comments

d7b33dc

better comments

17d98b7

vgeddes approved these changes Dec 30, 2024

View reviewed changes

yrong mentioned this pull request Jan 1, 2025

Add register ether command to control tool Snowfork/snowbridge#1361

Merged

acatangiu requested a review from serban300 January 7, 2025 12:10

bkchr approved these changes Jan 7, 2025

View reviewed changes

bkchr and others added 3 commits January 7, 2025 13:57

Apply suggestions from code review

c34c94b

Update Cargo.lock

60f65a9

Merge branch 'master' into alistair/support-eth

124e313

bkchr added this pull request to the merge queue Jan 7, 2025

Merged via the queue into paritytech:master with commit 4059282 Jan 7, 2025

acatangiu added the A4-needs-backport label Jan 8, 2025

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 8, 2025

[stable2407] Backport #6855 #7088

Closed

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 8, 2025

[stable2409] Backport #6855 #7089

Merged

paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 8, 2025

[stable2412] Backport #6855 #7090

Merged

acatangiu had a problem deploying to subsystem-benchmarks January 8, 2025 14:33 — with GitHub Actions Failure

aurexav reviewed Jan 9, 2025

View reviewed changes

alistair-singh deleted the alistair/support-eth branch January 9, 2025 10:50

github-actions bot mentioned this pull request Jun 10, 2025

Update polkadot-sdk from stable2412 to stable2503 moondance-labs/tanssi#1087

Closed

This was referenced Jul 16, 2025

Update polkadot-sdk from stable2412 to stable2503 moonbeam-foundation/moonbeam#3362

Closed

Update polkadot-sdk from stable2412 to stable2503-7 moonbeam-foundation/moonbeam#3363

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

	let message = VersionedMessage::decode_all(&mut envelope.payload.as_ref())
	.map_err(\|_\| Error::<T>::InvalidPayload)?;

Conversation

alistair-singh commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vgeddes commented Dec 18, 2024

Uh oh!

vgeddes commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yrong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alistair-singh Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yrong Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alistair-singh Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paritytech-cmd-bot-polkadot-sdk bot commented Jan 8, 2025

Uh oh!

paritytech-cmd-bot-polkadot-sdk bot commented Jan 8, 2025

Uh oh!

acatangiu commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paritytech-cmd-bot-polkadot-sdk bot commented Jan 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

alistair-singh commented Dec 12, 2024 •

edited

Loading

vgeddes commented Dec 20, 2024 •

edited

Loading

alistair-singh Dec 23, 2024 •

edited

Loading

yrong Jan 1, 2025 •

edited

Loading

alistair-singh Dec 23, 2024 •

edited

Loading

acatangiu commented Jan 8, 2025 •

edited

Loading