-
Notifications
You must be signed in to change notification settings - Fork 972
CI - zombienet cumulus tests zombienet sdk #8954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some last nits.
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/pov_recovery.rs
Show resolved
Hide resolved
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/pov_recovery.rs
Show resolved
Hide resolved
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/slot_based_authoring.rs
Outdated
Show resolved
Hide resolved
🧪 Test Results from Weekend Run –
|
This reverts commit 1bec14f.
There is no need to have two functions which are essentially doing the same. It is also better to oberserve the finalized blocks, which also simplifies the code. So, this pull request is replacing the `assert_para_throughput` with `assert_finalized_para_throughput`. It also replaces any usage of `assert_finalized_para_throughput` with `assert_para_throughput`.
This PR adds `wait_until_is_up()` methods as suggested [here](paritytech/polkadot-sdk#8954 (comment)). Additionally it fixes `test_wait_log_count_with_lookahead_regex_fails` test.
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/pov_recovery.rs
Outdated
Show resolved
Hide resolved
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/pov_recovery.rs
Outdated
Show resolved
Hide resolved
cumulus/zombienet/zombienet-sdk/tests/zombie_ci/elastic_scaling/pov_recovery.rs
Outdated
Show resolved
Hide resolved
…net-cumulus-tests-zombienet-sdk
🧪 Test Results from Nigtly Run –
|
Maybe we need to review the ranges after merging #9117 . Can you send me the plot (html). |
Here is the plot: chart_ci-zombienet-cumulus-tests-zombienet-sdk.html.zip Failures:
|
This PR includes the following changes:
zombienet-sdk
zombienet-cumulus-0009-elastic_scaling_pov_recovery
– #8999zombienet-cumulus-0010-elastic_scaling_multiple_block_per_slot
– #9018zombienet-cumulus-0011-dht-bootnodes
zombienet-cumulus-0012-parachain_extrinsic_gets_finalized
zombienet-cumulus-0013-elastic_scaling_slot_based_rp_offset