Skip to content

Fix regression benchmarks #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix regression benchmarks #9044

wants to merge 3 commits into from
+5 −1

Conversation

AndreiEres
Copy link
Contributor

No description provided.

@AndreiEres AndreiEres requested review from a team as code owners June 30, 2025 13:35
@AndreiEres AndreiEres added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jun 30, 2025
@AndreiEres AndreiEres requested a review from alvicsam June 30, 2025 13:36
@paritytech-review-bot paritytech-review-bot bot requested a review from a team June 30, 2025 19:23
@AndreiEres
Copy link
Contributor Author

@alexggh Could you take a look at the approval results, maybe we need to do something more than just update the thresholds?
https://github.com/paritytech/polkadot-sdk/actions/runs/15977846170/job/45064993553?pr=9044

@alexggh
Copy link
Contributor

alexggh commented Jul 1, 2025

@alexggh Could you take a look at the approval results, maybe we need to do something more than just update the thresholds? https://github.com/paritytech/polkadot-sdk/actions/runs/15977846170/job/45064993553?pr=9044

updating the thresholds should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
R0-no-crate-publish-required The change does not require any crates to be re-published.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreiEres @alexggh @alvicsam