XCM precompile: don't support older xcm versions #9126
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkontur
reviewed
Jul 8, 2025
| @@ -76,6 +76,12 @@ where | |||
| ) | |||
| .map_err(|error| revert(&error, "XCM send failed: Invalid message format"))?; | |||
|
|
|||
| // We don't allow older XCM versions. | |||
| let version = final_message.identify_version(); | |||
| if version == v3::VERSION || version == v4::VERSION { | |||
There was a problem hiding this comment.
What about this?
Suggested change
| if version == v3::VERSION || version == v4::VERSION { | |
| if version < v5::VERSION { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest XCM version is 5. A lot of parachains are still running V3 or V4 which is why we haven't removed them, but the XCM precompile is new and should only have to deal with versions 5 and onwards. No need to keep dragging 3 and 4 in contracts.