Merged
Conversation
This commit updates the hyper dependency to version 1.6.0. Changes: - Updated hyper dependency in Cargo.toml - Updated Cargo.lock with new hyper version - Modified prometheus.rs to use the new hyper API The changes matches closely the implementation in the SDK substrate util prometheus lib. Fixes #1011
niklasad1
reviewed
Apr 15, 2025
| Ok(response) | ||
| } | ||
|
|
||
| pub struct GracefulShutdown(Option<oneshot::Sender<()>>); |
Contributor
There was a problem hiding this comment.
It makes sense to remove this because we never stop the server ourselves just needless complexity.
I think did this change in polkadot-sdk as well :P
niklasad1
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the hyper dependency to version 1.6.0.
Changes:
Updated hyper dependency in Cargo.toml
Updated Cargo.lock with new hyper version
Modified prometheus.rs to use the new hyper API
The changes closely match the implementation in the SDK substrate util prometheus library.
Fixes #1011