tests: add e2e tests for multi-block miner#1040
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds end-to-end tests for the multi-block miner by introducing a new integration test and enhancing related configuration and CI workflows. The key changes include:
- Adding a new configuration file (zombienet-staking-runtimes.toml) to define relaychain and parachain settings for the e2e tests.
- Creating a new integration test suite in tests/multi_block_monitor.rs that validates the multi-block monitor functionality.
- Updating Cargo.toml and several GitHub workflow files to support the integration tests and ensure all required components (like zombienet and Node.js) are installed and verified.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| zombienet-staking-runtimes.toml | Added configuration for relaychain and parachain nodes. |
| tests/multi_block_monitor.rs | Introduced E2E tests for the multi-block miner and blockchain events monitoring. |
| Cargo.toml | Added the integration-tests feature flag. |
| .github/workflows/nightly.yml | Configured Node.js setup and zombienet installation for nightly builds. |
| .github/workflows/build-polkadot-for-nightly.yml | Enhanced build steps to include additional polkadot artifacts and chain specs. |
| .github/workflows/actions/prepare-binaries/action.yml | Modified binary preparation to include chain spec files placement. |
niklasad1
commented
Apr 30, 2025
niklasad1
commented
Apr 30, 2025
* Update multiblock metadata (tracking SDK rev 8da42e8fae) `desired_targets` storage item now requires the round index as a parameter, so this change correctly aligns our code with the updated storage API in the Polkadot SDK. See [SDK PR](paritytech/polkadot-sdk#8304). * Handle round parameter in snapshot functions [SDK #8304](https://github.com/paritytech/polkadot-sdk/pull/8304/files) has introduced a breaking change for which also snapshot methods are keyed on round index. Update the code accordingly. * Fix fmt
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.2.1 to 4.3.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4.2.1...v4.3.0) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 4.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Do not rely on specific text in polkadot logs but on the parachain collator to be up and running on the RPC port specified on the zombienet configuration.
sigurpol
approved these changes
May 13, 2025
Contributor
|
Let's merge in order to ensure all needed artifacts (binaries, chainspec) are in place and let's improve / fix / iterate. |
sigurpol
added a commit
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds end-to-end tests for the multi-block miner by introducing a new integration test running against latest and greatest
polkadot-sdk, and enhancing related configuration and CI workflows. The key changes include:Adding a new configuration file (zombienet-staking-runtimes.toml) to define relaychain and parachain settings for the e2e tests.
Creating a new integration test suite in tests/multi_block_monitor.rs that validates the multi-block monitor functionality.
Updating Cargo.toml and several GitHub workflow files to support the integration tests and ensure all required components (like zombienet and Node.js) are installed and verified.
Close #979