Adjust GHA to build runtimes from fellows and sdk repos #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
suggested changes
Oct 23, 2023
|
|
||
| - name: Srtool build | ||
| id: srtool_build | ||
| if: ${{ steps.cache_runtime.outputs.cache-hit != 'true' }} | ||
| uses: chevdor/srtool-actions@v0.8.0 | ||
| uses: chevdor/srtool-actions@wk-230920-add-debug |
There was a problem hiding this comment.
The extra debug and clean is nice but it does not explain the need to go offroad.
I would suggest staying the a release tag.
There was a problem hiding this comment.
Totally agree, then we need to wait till those changes are going to be released
There was a problem hiding this comment.
Do we really need the extra debug and fixes ?
There was a problem hiding this comment.
seems like the fix is needed, cause with the current released version 0.8.0 it was failing
chevdor
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts both GHA's to build runtimes from the
fellowshipandsdkrepos:polkadot-sdkorpolkadot-fellows/runtimes)