Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

CountedNMap implementation#10621

Merged
paritytech-processbot[bot] merged 71 commits intoparitytech:masterfrom
Mr-Leshiy:counted-double-map
Aug 4, 2023
Merged

CountedNMap implementation#10621
paritytech-processbot[bot] merged 71 commits intoparitytech:masterfrom
Mr-Leshiy:counted-double-map

Conversation

@Mr-Leshiy
Copy link
Copy Markdown
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 10, 2022 •
edited
Loading

add CountedStorageNMap implementation which is similar as CountedStorageMap for StorageMap but for the StorageNMap
#10602

polkadot address: 16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B

@Mr-Leshiy
Copy link
Copy Markdown
Contributor Author

Mr-Leshiy commented Feb 11, 2022 •
edited
Loading

@bkchr , @shawntabrizi don't want to be tactless, but can we proceed with this PR, it will be helpful to solve this issue paritytech/polkadot-sdk#316. Also after if this PR will be approved and merged I will prepare the same update for the StorageNMap.

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 19, 2022
@kianenigma
Copy link
Copy Markdown
Contributor

kianenigma commented Mar 19, 2022

This PR seems valuable, yet hat slipped through the crack. Partially due to lack of labeling and project assignment from our side. Hopefully will get some review soon. Thanks @Mr-Leshiy!

gui1117
gui1117 approved these changes Jul 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment thread frame/support/test/tests/pallet.rs
Comment thread frame/support/test/tests/pallet.rs
@jasl
Copy link
Copy Markdown
Contributor

jasl commented Jul 31, 2023

kindly ping

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Jul 31, 2023

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jul 31, 2023 •
edited
Loading

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-d8960438-2c53-404a-965d-8c59ae22d0ed to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jul 31, 2023

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3298354/artifacts/download.

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Jul 31, 2023

@Mr-Leshiy please note that there are some formatting issues that bot fmt is not able to solve. Could you please look into that?

@jasl
Copy link
Copy Markdown
Contributor

jasl commented Aug 2, 2023

@juangirini
Sorry for bothering you, but is this mergeable now?

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Aug 2, 2023

@sam0x17 @KiChjang There were some changes since your las reviews, would you give it another look before merging?

@jasl
Copy link
Copy Markdown
Contributor

jasl commented Aug 4, 2023

Could it be merged? this is really an awesome feature

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Aug 4, 2023

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 4, 2023

Error: Statuses failed for 4c29a0e

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Aug 4, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 4, 2023

Rebased

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Aug 4, 2023

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 4, 2023

Waiting for commit status.

@kianenigma
Copy link
Copy Markdown
Contributor

kianenigma commented Aug 4, 2023

/tip medium

@substrate-tip-bot
Copy link
Copy Markdown

substrate-tip-bot bot commented Aug 4, 2023

@Mr-Leshiy Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@kianenigma
Copy link
Copy Markdown
Contributor

kianenigma commented Aug 12, 2023

@Mr-Leshiy interested in a tip?

@Mr-Leshiy
Copy link
Copy Markdown
Contributor Author

Mr-Leshiy commented Aug 13, 2023

@kianenigma would be great :)
16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B

@juangirini
Copy link
Copy Markdown
Contributor

juangirini commented Aug 14, 2023

/tip medium

@substrate-tip-bot
Copy link
Copy Markdown

substrate-tip-bot bot commented Aug 14, 2023

@juangirini A medium (80 DOT) tip was successfully submitted for @Mr-Leshiy (16GBceb9xiWB1R5YQGRfEYDZbWcatmLz8MPd6KZYpy4qfV7B on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda tip

@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@melekes melekes melekes left review comments

@shawntabrizi shawntabrizi shawntabrizi left review comments

@sam0x17 sam0x17 sam0x17 approved these changes

@KiChjang KiChjang KiChjang approved these changes

@gui1117 gui1117 gui1117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mr-Leshiy Mr-Leshiy

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

Runtime / FRAME
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CountedDoubleMap, CountedNMap implementation missing