bugfix: panic when type unmatch between toml and struct#236
Merged
pelletier merged 3 commits intopelletier:masterfrom Sep 18, 2018
Merged
bugfix: panic when type unmatch between toml and struct#236pelletier merged 3 commits intopelletier:masterfrom
pelletier merged 3 commits intopelletier:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 9 9
Lines 1649 1649
=======================================
Hits 1459 1459
Misses 135 135
Partials 55 55
Continue to review full report at Codecov.
|
Owner
|
Thanks for your PR! Looks like it's also gonna help with #219! I pulled your changes and tried with the example you gave, but I'm getting |
Contributor
Author
This is the output I got, it seems ok? |
Owner
|
Interesting. With type Postgres struct {
Id int64
}
type Config struct {
Postgres Postgres
}
doc := []byte(`
[Postgres]
Id = 1e3
`)
config := Config{}
toml.Unmarshal(doc, &config)
fmt.Println("id=", config.Postgres.Id)I get |
Contributor
Author
|
1.9.2 |
Owner
|
Thanks! Sorry took so long to merge that. I was actually doing something silly, the patch works well. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When type unmatch between toml and struct, will panic.
Example:
Panic: