Add support for JSON column in column_info() #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dveeden
reviewed
Apr 15, 2025
dveeden
approved these changes
Apr 15, 2025
Field storage requirement for JSON column is approximately the same as for a LONGBLOB or LONGTEXT column. It's defined in https://dev.mysql.com/doc/refman/8.4/en/storage-requirements.html#data-types-storage-reqs-json
michal-josef-spacek
force-pushed
the
add_support_for_json_in_column_info
branch
from
0dc4cdf to
56473ca
Compare
|
I am for adding tests later. There are tests in 40catalog.t for column_info(), but not for column types. btw: I am preparing a test for JSON type to DBD::MariaDB (michal-josef-spacek/DBD-MariaDB@e849a7a) and I touched this issue. We need to resolve SQL_DBMS_NAME first before the possibility of adding this test in DBD::mysql. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field storage requirement for JSON column is approximately the same as for a LONGBLOB or LONGTEXT column.
It's defined in
https://dev.mysql.com/doc/refman/8.4/en/storage-requirements.html#data-types-storage-reqs-json