Skip to content

Fix container name display when running non-file types (fixes #2639). #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davidmatson
Copy link
Contributor

@davidmatson davidmatson commented Apr 8, 2025

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

Use a helper that formats the container name correctly for all container
types, notably also for ScriptBlocks.

fixes #2639

@davidmatson
Copy link
Contributor Author

@nohwnd / @fflaten - I'm hoping this is a simple fix; please let me know what you think - thanks!

@nohwnd
Copy link
Member

nohwnd commented May 2, 2025

Please add a test for it, this is probably the best place: https://github.com/pester/Pester/blob/main/tst/Pester.RSpec.Output.ts.ps1

…2639).

Use a helper that formats the container name correctly for all container
types, notably also for ScriptBlocks.
@davidmatson davidmatson force-pushed the user/dmatson/fixRunningScriptBlockContainerName branch from b064143 to 17a37f1 Compare May 2, 2025 22:13
@davidmatson
Copy link
Contributor Author

Please add a test for it, this is probably the best place: https://github.com/pester/Pester/blob/main/tst/Pester.RSpec.Output.ts.ps1

sure - done!

@nohwnd nohwnd merged commit 5a1bd5b into pester:main May 5, 2025
11 checks passed
@davidmatson davidmatson deleted the user/dmatson/fixRunningScriptBlockContainerName branch May 5, 2025 16:32
@nohwnd
Copy link
Member

nohwnd commented May 10, 2025

/backport to rel/5.x.x

Copy link

Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/14946885819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Running tests from ..." is not displayed for ScriptBlock containers.
2 participants