Skip to content

Adds option to signoff commits #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Adds option to signoff commits #476

merged 5 commits into from
Jul 31, 2020

Conversation

pvogt09
Copy link
Contributor

@pvogt09 pvogt09 commented Jul 30, 2020

This PR adds the ability to signoff the automatically created commits to enable DCO requirements for pull requests.
It adds the option signoff and the flag -s to git commit which adds "Signed-off-by: author < email >" with the value of commiter to the commit message.

Test cases for the new option are not included.

@peter-evans
Copy link
Owner

@pvogt09 Thank you for this contribution! I had not heard of DCO before so I learnt something new. 😄
I'm not sure how common it is to use this, but I can see it would be a useful feature for those that do.

I'm going to merge this to the dev branch first so I can add unit and system tests. After that I'll merge it to master and release.

In the meantime, if you want to use this action right away you can make your own commits and add the -s option.
See https://github.com/peter-evans/create-pull-request#controlling-commits

@peter-evans peter-evans changed the base branch from master to dev July 31, 2020 06:12
@peter-evans peter-evans merged commit bf7dd38 into peter-evans:dev Jul 31, 2020
@peter-evans
Copy link
Owner

Merged and released. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants