Implement LoggerType#dump#85
Merged
Merged
Conversation
david942j
commented
Jan 26, 2018
| # This method do the following things: | ||
| # 1. Get the source code from file (using gem `method_source`) | ||
| # 2. Parse the source code to Sexp using `ruby_parser` | ||
| # 3. Traverse the sexp and find the block argument when calling `:dump` |
hanhanW
reviewed
Jan 26, 2018
| # This method doesn't work in a REPL shell. | ||
| # | ||
| # @note | ||
| # The source code in block will be parsed using +ruby_parser+, |
Collaborator
There was a problem hiding this comment.
will be parsed by using +ruby_parser+
Collaborator
|
Support |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #62
Hacky methods are used:
method_source)Sexp(usingruby_parser)dumpruby2ruby)Therefore, some unusual usages will fail, such as:
log.dump(&a_proc)#nilwill be loggedlog.dump { 1 }; log.dump { 2 }# will log1two timesTwo new dependencies are added:
method_sourceruby2rubyThis change is