Skip to content

Remove dead code from openssl_spki_new() implementation #18752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jun 3, 2025

If s is not NULL, the length can't be <= 0 because we at least append spkac in the string, which is non-empty.
I noticed this condition because if it were actually possible to execute, then it would leak memory.

If s is not NULL, the length can't be <= 0 because we at least append
`spkac` in the string, which is non-empty.
I noticed this condition because if it were actually possible to
execute, then it would leak memory.
@nielsdos nielsdos merged commit dbabbe1 into php:master Jun 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants