[RFC] Allow hooks for backed readonly properties
#18757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickSdot
force-pushed
the
allow-readonly-hooks
branch
3 times, most recently
from
1a21998 to
6840873
Compare
Crell
reviewed
Jun 6, 2025
Crell
reviewed
Jun 6, 2025
NickSdot
force-pushed
the
allow-readonly-hooks
branch
from
da64264 to
24f2687
Compare
NickSdot
force-pushed
the
allow-readonly-hooks
branch
from
c06c915 to
12b986a
Compare
NickSdot
changed the title
readonly propertiesreadonly properties
TimWolla
reviewed
Jun 9, 2025
| int(42) | ||
| Cannot modify readonly property Test::$prop | ||
| Cannot modify protected(set) readonly property Test::$prop from global scope | ||
| int(42) |
There was a problem hiding this comment.
Please make sure to include the trailing newline at EOF (also applies to other tests).
There was a problem hiding this comment.
This test does not appear to belong to this PR.
| Cannot modify readonly property Test::$prop | ||
| Cannot modify protected(set) readonly property Test::$prop from global scope | ||
| int(42) | ||
|
|
There was a problem hiding this comment.
this appears to be a newline too many.
| try { | ||
| $t->set(43); | ||
| } catch (Error $e) { | ||
| echo $e->getMessage(), "\n"; |
There was a problem hiding this comment.
Suggested change
| echo $e->getMessage(), "\n"; | |
| echo $e::class, ": ", $e->getMessage(), PHP_EOL; |
For consistency with other tests (applies to the entire PR).
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| Fatal error: Hooked virtual properties cannot be readonly in %s on line %d |
There was a problem hiding this comment.
This error message is misleading.
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| Fatal error: Hooked virtual properties cannot be readonly in %s on line %d |
There was a problem hiding this comment.
This error message is misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/readonly_hooks
https://news-web.php.net/php.internals/127529