[RFC] Allow hooks for backed readonly properties

[NickSdot]

https://wiki.php.net/rfc/readonly_hooks
https://news-web.php.net/php.internals/127529

[TimWolla]

Suggested change

	echo $e->getMessage(), "\n";
	echo $e::class, ": ", $e->getMessage(), PHP_EOL;

For consistency with other tests (applies to the entire PR).

[NickSdot]

Hi Tim,

I based my approach on the tests in the existing property_hooks directory I was working in. Everything was written in the same style as I initially used here. Moreover, single quotation marks are used in other tests (outside of this directory).

- echo $e::class, ": ", $e->getMessage(), PHP_EOL;
+ echo $e::class, ': ', $e->getMessage(), PHP_EOL;

As I am new here, I have no preference and have made the change as you requested (but with single quotes, ok?).

However, since my tests are now the only ones with this style in the directory, I thought I would mention it in case we want to follow up with an unification PR for the old tests.

(I will not mark as resolved here. Please do it if you consider it done – thanks!)

[NickSdot]

Larry (@Crell) correctly pointed out that the error messages for ZEND_ACC_IMPLICIT_ABSTRACT_CLASS and ZEND_ACC_EXPLICIT_ABSTRACT_CLASS also could be separated into two messages, instead of merging them into one.

Currently we have a single one for the both abstract types:

Hooked properties in abstract classes cannot be declared readonly

There could be two:

Hooked properties in abstract classes cannot be declared readonly
Abstract properties cannot be declared readonly

We would appreciate opinions on that! 🙂

cc @TimWolla, because this is a follow up to your "misleading errors" change request.