-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ext/bcmath: Performance improvement bcsqrt()
#18771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SakiTakamachi
wants to merge
7
commits into
php:master
Choose a base branch
from
SakiTakamachi:bcmath/optimize_sqrt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbfe6d5
to
9cf6b03
Compare
sqrt()
bcsqrt()
bd573f4
to
b60f757
Compare
03f3124
to
8d619bd
Compare
bcsqrt()
bcsqrt()
Sorry, it was still incomplete. |
193a1a5
to
9c4af5c
Compare
9c4af5c
to
70613a0
Compare
70613a0
to
d7d1d80
Compare
The code is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
Approximately 80 million calculations were performed using values of various magnitudes and scales, and all results matched those from the previous implementation.
Benchmark
Performance improvements are particularly noticeable in the following cases:
For large values that do not fall into the above categories, most of the execution time is spent on the iterative process of the Newton-Raphson method, especially on division operations. As a result, while there may be some minor gains from reducing memory allocations and lowering the cost of converting BCD to BC_VECTOR, there is no significant improvement in overall performance.
Small size value (fast path)
Code:
Result:
Middle size value (< 1) (standard path)
Code:
Result:
Middle size value 1 (fast path)
The new logic ignores unnecessary scales in the calculation, so this is a fast path.
Code:
Result:
Middle size value 2 (standard path)
Code:
Result:
Big size value (standard path)
Code:
Result: