Skip to content

ext/pdo_sqlite: fix minimal version for EXPLAIN feature support. #18854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025

Conversation

devnexen
Copy link
Member

found out while working on #18853

ref.

@devnexen devnexen linked an issue Jun 18, 2025 that may be closed by this pull request
@NattyNarwhal
Copy link
Member

Fewer differences than before:

--
         ["p1"]=>
         int(0)
         ["p2"]=>
012-     int(14)
012+     int(15)
         ["p3"]=>
         int(0)
         ["p4"]=>
--
         ["p1"]=>
         int(3)
         ["p2"]=>
031-     int(7)
031+     int(8)
         ["p3"]=>
         int(2)
         ["p4"]=>
--
         ["addr"]=>
         int(2)
         ["opcode"]=>
046+     string(7) "Explain"
047+     ["p1"]=>
048+     int(2)
049+     ["p2"]=>
050+     int(0)
051+     ["p3"]=>
052+     int(0)
053+     ["p4"]=>
054+     string(20) "SCAN 2 CONSTANT ROWS"
055+     ["p5"]=>
056+     int(0)
057+     ["comment"]=>
058+     NULL
059+   }
060+   [3]=>
061+   array(8) {
062+     ["addr"]=>
063+     int(3)
064+     ["opcode"]=>
         string(7) "String8"
         ["p1"]=>
         int(0)
--
         ["p1"]=>
         int(3)
         ["p2"]=>
164-     int(13)
183+     int(14)
         ["p3"]=>
         int(0)
         ["p4"]=>
--
         ["p1"]=>
         int(0)
         ["p2"]=>
240-     int(8)
259+     int(9)
         ["p3"]=>
         int(0)
         ["p4"]=>
--

@NattyNarwhal
Copy link
Member

Just the additional entry now:

--
         ["addr"]=>
         int(2)
         ["opcode"]=>
046+     string(7) "Explain"
047+     ["p1"]=>
048+     int(2)
049+     ["p2"]=>
050+     int(0)
051+     ["p3"]=>
052+     int(0)
053+     ["p4"]=>
054+     string(20) "SCAN 2 CONSTANT ROWS"
055+     ["p5"]=>
056+     int(0)
057+     ["comment"]=>
058+     NULL
059+   }
060+   [3]=>
061+   array(8) {
062+     ["addr"]=>
063+     int(3)
064+     ["opcode"]=>
         string(7) "String8"
         ["p1"]=>
         int(0)
--

@NattyNarwhal
Copy link
Member

Unfortunately doesn't change the output.

@devnexen devnexen force-pushed the pdo_sqlite_last_correction branch from 7ac0c89 to e67a0e7 Compare June 18, 2025 17:24
Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes it!

PASS Pdo\Sqlite::ATTR_EXPLAIN_STATEMENT usage [ext/pdo_sqlite/tests/subclasses/pdo_sqlite_getsetattr_explain.phpt] 

@devnexen
Copy link
Member Author

Yay ! Note to myself, to apply similar fixes to the pure sqlite version !

@devnexen devnexen merged commit f129586 into php:master Jun 18, 2025
9 checks passed
@devnexen devnexen deleted the pdo_sqlite_last_correction branch June 18, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdo_sqlite_getsetattr_explain.phpt test is sensitive to variance
2 participants