Skip to content

Conversation

@herndlm
Copy link
Contributor

@herndlm herndlm commented Jul 6, 2022

Closes phpstan/phpstan#7580

There were 2 issues basically which is why I split this into 2 commits

StrSplitFunctionReturnTypeExtension could need a bit more cleanup, but I wanted to avoid rewriting it here.. Maybe I'll adapt some more in follow-ups.

@herndlm herndlm marked this pull request as ready for review July 6, 2022 09:03
@mvorisek
Copy link
Contributor

mvorisek commented Jul 7, 2022

FYI, str_split will return empty array for empty string since PHP 8.2, see php/php-src#8945

@herndlm
Copy link
Contributor Author

herndlm commented Jul 7, 2022

FYI, str_split will return empty array for empty string since PHP 8.2, see php/php-src#8945

oh good to know and it least it's consistent then. I'd adapt that in a follow-up if that's ok :) UPDATE: after your linked PR gets merged of course

@ondrejmirtes ondrejmirtes merged commit ef19bb7 into phpstan:1.8.x Jul 10, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the fix-7580 branch July 10, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mb_str_split result can be an empty array

3 participants