`forwarded` property missing in `/history/database` API response

[vermacodes]

Versions

• Pi-hole: v6.3
• Web: v6.4
• FTL: v6.4.1

Platform

• OS and version: Alpine Linux (Pi-hole Docker image)
• Platform: Docker (docker-compose)

Expected behavior

GET call to /history/database API endpoint should give number of calls 'forwarded' like in following example from api docs.

{
  "history": [
    {
      "timestamp": 1511819900.539157,
      "total": 2134,
      "cached": 525,
      "blocked": 413,
      "forwarded": 1196
    },
    {
      "timestamp": 1511820500.583821,
      "total": 2014,
      "cached": 52,
      "blocked": 43,
      "forwarded": 1910
    }
  ],
  "took": 0.003
}

Actual behavior / bug

'Forwarded' metric is not part of the response object.

{
  "history": [
    {
      "timestamp": 1765314000,
      "total": 288,
      "cached": 204,
      "blocked": 61
    },
    {
      "timestamp": 1765314600,
      "total": 48,
      "cached": 33,
      "blocked": 12
    }
  ],
  "took": 0.0009014606475830078
}

Steps to reproduce

1. Open https://pi.hole/api/docs/#get-/history/database (Replace the hostname as per your setup)
2. Authenticate and update API Server Variables.
3. Open GET /history/database
4. Add from and until query parameters.
5. Hit 'Try' button
6. Observe that the response doesn't contain forwarded property.

You can copy the CURL command with SID and try that as well.

Expected fix:
The API response should honor the schema and include the forwarded property.

[vermacodes]

While reviewing the code, I noticed what looks like a potential issue around stats_database.c#L137. It seems that the forwarded field may not be added to the object as expected.

Would you prefer that I open a dedicated issue in the FTL repository to track this, or is it fine to continue the discussion here? I’d be happy to help investigate further or even contribute a fix if that would be useful.

Thanks again for your time and effort on this project, it’s greatly appreciated

[yubiuser]

I think we don't even use this API endpoint anymore. It was meant to create the long-term data graph, but this was never ported to v6. While I can see why this could be a valuable endpoint for some users, I wonder if we could combine /history and /history/database by making from and until optional and if not provided responde with the data for the last 24 hours

[rdwebdesign]

Maybe we can use disk=true like we do for /api/queries

[DL6ER]

Will be fixed by #2750