-
-
Notifications
You must be signed in to change notification settings - Fork 24
Refactor and cleanup FTL build workflows #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PromoFaux
wants to merge
4
commits into
master
Choose a base branch
from
rework-gha-yaml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+220
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2085629 to
6baa5d7
Compare
Member
|
Looks like the security scan bot has left some comments and suggestions for limiting access. |
Member
Author
|
They've been addressed :) |
dschaper
approved these changes
Dec 17, 2025
DL6ER
reviewed
Dec 21, 2025
4559f4c to
bfe9929
Compare
- tag nightly builds on both schedule and push to master branch - tag latest on release types - only set up QEMU for relevant platform - No need for QEMU on the merge job - Set riscv64 runner to arm variant - utilise YAML anchors to reduce duplication - separate publish and test jobs to make it easier to follow Signed-off-by: Adam Warner <[email protected]>
…ent. Implement retry logic from the FTL repo remove redundant environment variable definitions. Signed-off-by: Adam Warner <[email protected]>
bfe9929 to
d534b22
Compare
Signed-off-by: Adam Warner <[email protected]>
234a742 to
b349b00
Compare
…a-file and read it in the next step Signed-off-by: Adam Warner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
I had initially wanted just to add in an additional condition for tagging
nightly, however while I was there I took some inspiration from the build process of the docker-pi-hole imageBy submitting this pull request, I confirm the following:
git rebase)