fix: updated lc handbook 01 #469
Merged
+1,658
−836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…templates.ipynb to Work with LangChain 0.3 (#451) Used newer models and new HuggingFaceEndpoint() class (instead of the, now deprecated, HuggingFaceHub() class. Changed the LLM from text-davinci-003 to gpt-3.5-turbo, since the former is deprecated. Had to change the example from prompting the LLM to make jokes in response to serious questions, to a Markdown formatting task, as newer LLMs are too good at following orders and the supposedly bad responses were not actually bad. ## Problem Describe the purpose of this change. What problem is being solved and why? ## Solution Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Describe specific steps for validating this change. --------- Co-authored-by: James Briggs <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Lol I've ran into similar issues with generations now. Will review soon. |
arjunpatel7
approved these changes
Jun 25, 2025
|
LGTM, passes our run test so can be run as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to change the example from prompting the LLM to make jokes in response to serious questions, to a Markdown formatting task, as newer LLMs are too good at following orders and the supposedly bad responses were not actually bad.
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change