Skip to content

fix: update lc handbook 02 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

fix: update lc handbook 02 #470

merged 4 commits into from
Jun 25, 2025

Conversation

jamescalam
Copy link
Collaborator

Changes:

  • Import langchain-community as it's required for from langchain.callbacks import get_openai_callback.
  • Import numexpr as it's required by LLMMathChain.
  • Updated to use LCEL, rather than importing Chain classes.
  • Removed LangChain Hub part at end of Notebook as it was used for importingt the deprecated LLMathChain

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

…ipynb to Work with LangChain 0.3 (#452)

Changes:
- Import `langchain-community` as it's required for `from
langchain.callbacks import get_openai_callback`.
- Import `numexpr` as it's required by `LLMMathChain`.
- Updated to use LCEL, rather than importing Chain classes.
- Removed LangChain Hub part at end of Notebook as it was used for
importingt the deprecated LLMathChain

## Problem

Describe the purpose of this change. What problem is being solved and
why?

## Solution

Describe the approach you took. Link to any relevant bugs, issues, docs,
or other resources.

## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

Describe specific steps for validating this change.
@jamescalam jamescalam self-assigned this Jun 25, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@arjunpatel7 arjunpatel7 self-requested a review June 25, 2025 18:34
Copy link
Contributor

@arjunpatel7 arjunpatel7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Passes tests, doesn't use Pinecone, has version numbers, etc. Thank you!

@arjunpatel7 arjunpatel7 merged commit 6109695 into master Jun 25, 2025
9 checks passed
@arjunpatel7 arjunpatel7 deleted the james/lc-02-update branch June 25, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants