Improve getting-started section's docker compose #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NihalJain
force-pushed
the
docker_compose_kafka
branch
3 times, most recently
from
acfa086 to
6d68280
Compare
|
Was trying to setup pinot via docker, thought this might be useful and make things easier, hence raised PR. CC: @Jackie-Jiang |
NihalJain
force-pushed
the
docker_compose_kafka
branch
from
6d68280 to
e56074a
Compare
- Add support to optionally start kafka - Align with manual docker steps like networks configsurations - Improve script and add health checks for each service - Make image tags configurable and create sub-sections as needed
NihalJain
force-pushed
the
docker_compose_kafka
branch
from
e56074a to
45ee4b9
Compare
|
Hi reviewers does this change look good to you all? |
xiangfu0
approved these changes
Nov 19, 2024
|
Thanks @NihalJain for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.