Fixes to use the same buffer as input and output #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 80.56% 80.62% +0.06%
==========================================
Files 18 18
Lines 1662 1683 +21
==========================================
+ Hits 1339 1357 +18
- Misses 221 223 +2
- Partials 102 103 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added checks for the same buffer to stop copying data when not needed. Also fixed srtpCipherAesCmHmacSha1 to work with one buffer when encrypting and decrypting RTCP packets.
sirzooro
force-pushed
the
same_buffer_fixes
branch
from
4227879 to
a50d986
Compare
at-wat
approved these changes
Jun 10, 2025
| @@ -59,9 +63,7 @@ func (c *Context) decryptRTCP(dst, encrypted []byte) ([]byte, error) { | |||
| } | |||
| } | |||
|
|
|||
| out := allocateIfMismatch(dst, encrypted) | |||
There was a problem hiding this comment.
note: allocateIfMismatch handled nil dst but growBuffer in cipher.decryptRTCP also handles nil output buffer
| sameBuffer := isSameBuffer(dst, encrypted) | ||
|
|
||
| if !sameBuffer { | ||
| copy(dst, encrypted[:srtcpHeaderSize]) // Copy the first 8 bytes (RTCP header) |
There was a problem hiding this comment.
Looks like the original code didn't do this?
There was a problem hiding this comment.
allocateIfMismatch seems to have copied the buffer.
Fixed code is nice👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for the same buffer to stop copying data when not needed. Also fixed srtpCipherAesCmHmacSha1 to work with one buffer when encrypting and decrypting RTCP packets.