pion/webrtc@v4 Release

[Sean-Der]

Pion WebRTC Migration Status

This is a running list of projects that need to be migrated to v4. I would love to see a community effort to migrate and fix bugs/improve things as we learn from it.

• LiveKit Projects
  • TODO
• example-webrtc-applications
• Broadcast Box
• rtsp-bench
• webrtc-voicemail
• rtwatch
• offline-browser-communication

---

See https://github.com/pion/webrtc/wiki/Release-WebRTC%40v4.0.0 for the release notes

[edaniels]

Not needed but may be good to address #2292

[aalekseevx]

Maybe we can revert this revert as networkType is not "tcp4"/"tcp6"/etc according to the webrtc-stats?

[aalekseevx]

Also, I find very confusing that we have
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGathererState))
not
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGatheringState))

even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState

I suggest it is worth making more consistent

[at-wat]

even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState

@aalekseevx Do you mean to do polling instead of event callback?

[aalekseevx]

@at-wat, no, I think this change would be too radical :) I'm just suggesting changing the return type of OnICEGatheringStateChange from ICEGathererState to ICEGatheringState (both types already present in implementation). Mapping could be done this way

[Sean-Der]

@aalekseevx nice catch! I will make both changes