fix(selected-list): remove redundant (and w/ invalid html) label #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The same as #506 but for v1, thanks @quadule for the PR and @tobischo for reporting the issue.
Detail
Basically removes a redundant line intended for creating the label for the input.
The line had 2 issues:
content_tag
method was called incorrectly, with the whole label as argument instead of the tag type as first argument and options as second. It was generating invalid HTML, eg.<_label_for__X__class__label__Y__label_></_label_for__X__class__label__Y__label_>
which was completely malformed.Checklist
Before submitting the PR make sure the following are checked: