Skip to content

fix(selected-list): remove redundant (and w/ invalid html) label #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

rjherrera
Copy link
Member

Motivation / Background

The same as #506 but for v1, thanks @quadule for the PR and @tobischo for reporting the issue.

Detail

Basically removes a redundant line intended for creating the label for the input.

The line had 2 issues:

  1. The label was already created in a "parent" method (here).
  2. The content_tag method was called incorrectly, with the whole label as argument instead of the tag type as first argument and options as second. It was generating invalid HTML, eg. <_label_for__X__class__label__Y__label_></_label_for__X__class__label__Y__label_> which was completely malformed.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • Documentation has been added or updated if you add a feature or modify an existing one.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

@rjherrera rjherrera merged commit ad98691 into v1 Dec 6, 2024
1 check passed
@rjherrera rjherrera deleted the f/selected-list-redundant-label branch December 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant