Skip to content

Add brotli import, perform triple colectomy #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2020
Merged

Add brotli import, perform triple colectomy #204

merged 4 commits into from
May 28, 2020

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented May 28, 2020

This minor PR aims to excise the unfortunate (and unexplained) occurrence of ::: in a call to getIdProps, and to add brotli to the package imports list. These changes are required to pass CRAN checks for submission to the repository.

The online help is now compliant with the format recommended for R6 classes by the maintainers of roxygen2.

N.B. Updating the dash package for CRAN will always require some manual editing of the DESCRIPTION file to remove the Remotes section and to delete the tests/integration subdirectory as well as any other items that are not used in the R package.

Ryan Patrick Kyle added 2 commits May 28, 2020 10:32
@rpkyle rpkyle requested a review from Marc-Andre-Rivet May 28, 2020 15:47
@rpkyle rpkyle self-assigned this May 28, 2020
Copy link
Contributor

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

💃

@rpkyle rpkyle merged commit a7aa5cb into dev May 28, 2020
@rpkyle rpkyle deleted the remove-warnings branch May 28, 2020 22:37
@rpkyle rpkyle mentioned this pull request May 28, 2020
rpkyle added a commit that referenced this pull request May 29, 2020
* Add dopsa test for proposed R build test (#199)

* Remove is.layout, layout_container_id, and redundant component test (#121)

* Add brotli import (#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants