-
Notifications
You must be signed in to change notification settings - Fork 632
Description
2/3 of these issues are already mentioned in #1178 but since that PR is merged, it would get lost there.
-
When the initial dragmode is zoom and I manually click on lasso selection, the plot stretches horizontally a bit (see GIF below)
-
Something in selecting/adding points is broken. Here is a GIF of what selecting some points and trying to add the same points back as a different colour looks like:
This does not happen with the current CRAN version of plotly. I assume this doesn't always happen, otherwise it would be noticed and fixed by now. I cannot provide reproducible code in this issue, but @cpsievert has access to code that has this problem. The repo at https://github.com/daattali/sievert-oil is an example of this issue -
Points aren't showing in RStudio. Using the same app from the private repo https://github.com/daattali/sievert-oil using the CRAN version the plot works absolutely fine within RStudio, but with the current github version, nothing shows up in the plot within RStudio Viewer.
Activity
cpsievert commentedon Mar 7, 2018
For (3), can you please report the console errors you are seeing?
daattali commentedon Mar 7, 2018
cpsievert commentedon Mar 7, 2018
Renders in RStudio on my mac. I assume you're on Windows? Does it render on in IE/Edge? Do these points render in IE/Edge? https://codepen.io/cpsievert/pen/oqvjXa
daattali commentedon Mar 7, 2018
cpsievert commentedon Mar 7, 2018
Ok, unfortunately I haven't been able to replicate (1) or (2). Do these problems happen universally (e.g. different browsers and states)?
nicolaskruchten commentedon Mar 7, 2018
I wonder if some of this stuff won't have been fixed by plotly/plotly.js#2437 ...
daattali commentedon Mar 7, 2018
cpsievert commentedon Mar 7, 2018
@daattali just upgraded to plotly.js 1.35.0 -- let me know if that helps/hurts anything
daattali commentedon Mar 7, 2018
@cpsievert latest version does fix the first issue with the plot dimensions getting slightly resized.
But the other issues are still appearing, LASSOing points causes points to jump around while the mouse is dragging, and new points are appearing in a place they shouldn't be when done. Using the same repo that you have (sorry for anyone else here, only Carson and I can access that code) I get this now (Chrome on Win7)
(sorry for the very low quality and confusing GIF, it takes me forever to make it even when they're this bad...)
daattali commentedon Mar 8, 2018
@cpsievert after another couple hours of debugging, it seems that when I don't use
toWebGL()
things look and work much betterdaattali commentedon Mar 8, 2018
@cpsievert I was trying to debug this on my very complicated app, but it seems like these issues are happening even for the most basic plots when converted to webgl.
Doesn't show any points in RStudio, and in chrome when I try to select points, they jump around. So I think it's
toWebGL()
that's brokendaattali commentedon Mar 8, 2018
I'm closing this as I opened individual issues with short reproducible code samples.
cpsievert commentedon Mar 8, 2018
yea, plotly.js devs recently completely rewrote the webgl logic, which is why we're running into headaches -- you can always use
scatter
(SVG) overscattergl
(canvas) and things should be less buggy, but it won't be as performantHuh, I can't replicate either of these issues. If you get the same behavior on this codepen, could you please post a plotly.js issue with a screen-recording (and tag me)?
https://codepen.io/cpsievert/pen/oqvjXa