Skip to content

Remove Math.sign #1773

@alexcjohnson

Description

@alexcjohnson
Collaborator

Math.sign is not supported in IE, even IE11. Currently we only seem to have this in gl2d/camera
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L134
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L152

We should remove these and include Math.sign (any other IE quirks?) in our syntax tests.

Activity

self-assigned this
on Jun 16, 2017
alexcjohnson

alexcjohnson commented on Jun 19, 2017

@alexcjohnson
CollaboratorAuthor

fixed by #1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething broken

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @alexcjohnson

      Issue actions

        Remove Math.sign · Issue #1773 · plotly/plotly.js