Closed
Description
Motivated by #63 ... we should describe this structure somewhere in the contributor's guide. What's generally supposed to be the role of attributes
, supplyDefaults
, supplyLayoutDefaults
, calc
, setPositions
, plot
, and style
(anything else?), how to tell the difference, and when each of them gets called. Without that it's pretty hard for new people to make any meaningful contributions to the drawing code. The non-trace modules (axes, annotations, etc...) may still be too ad-hoc for this kind of doc to be useful, but I think the traces are fairly uniform by now.
Of course if this leads us to the desperately needed refactor & modularization of restyle
and relayout
I wouldn't complain, but that shouldn't stop us from documenting what we have.
Metadata
Metadata
Assignees
Labels
No labels
Activity
etpinard commentedon Dec 3, 2015
the gl trace modules need a
convert
step too at the moment.etpinard commentedon Mar 3, 2020
I'll try to make a PR for this ticket before I go.
@archmoj is there anything in particular regarding the trace module structure that you'd like me to write on?
archmoj commentedon Mar 4, 2020
It would be helpful to know "when each of them gets called".
etpinard commentedon Mar 5, 2020
TODO:
etpinard commentedon Mar 11, 2020
⬆️ gif I'll add to the
CONTRIBUTING.md
doc.