Skip to content

Fix multi-axis transition "leaks" #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fix multi-axis transition "leaks" #4167

merged 1 commit into from
Sep 6, 2019
+145 −10

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Sep 5, 2019

fixes #4153 - by resetting the loop variables in old/new transition prepare loops

before: https://jsfiddle.net/9onwtvgu/
after: https://jsfiddle.net/seh2Lx1n/

cc @plotly/plotly_js

@etpinard
fix #4153 - reset loop variable in old/new transition prepare loops
41a5a83 
- this commits fixes both the `Plotly.animate` and
  the `Plotly.react` case.
@etpinard etpinard added bug something broken status: reviewable labels Sep 5, 2019
@archmoj
Copy link
Contributor

archmoj commented Sep 6, 2019

@etpinard Great fix.
💃

@etpinard etpinard merged commit 1aa0b6f into master Sep 6, 2019
@etpinard etpinard deleted the animate-range-edit-leak branch September 6, 2019 20:16
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@etpinard etpinard mentioned this pull request Mar 13, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axis animation with subplots leaks to other axis
2 participants
@etpinard @archmoj