Fix Plotly.react/Angular missing categories + axis tick labels #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrgss
commented
Dec 15, 2020
|
|
||
| afterEach(destroyGraphDiv); | ||
|
|
||
| function _hover(gd, opts) { |
Contributor
Author
There was a problem hiding this comment.
Borrowed from hover_label_test.js
plotly.js/test/jasmine/tests/hover_label_test.js
Lines 3712 to 3715 in 82da615
| return Plotly.react(gd, fig); | ||
| }) | ||
| .then(function() { | ||
| expect(gd._fullLayout.xaxis._categories).toEqual(['a', 'b', 'c', 'd']); |
Contributor
Author
There was a problem hiding this comment.
Fails with empty array ([]) on master
| }) | ||
| .then(function() { | ||
| _hover(gd, { xval: fig.data[0].x.indexOf('a') }); | ||
| expect(d3.selectAll('g.axistext').select('text').html()).toEqual('a'); |
Contributor
Author
There was a problem hiding this comment.
Fails with empty string ('') on master
Contributor
|
Great fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5318 + adds a test. Many thanks to @alexcjohnson for uncovering this solution and reproducing in CodePen! 🙂
All Jasmine expectations in the new test should fail on
master.Demo:
Before vs After
I also recreated the Angular environment in #5318 and confirmed that this fixes the problem. However, while I can use the build of plotly.js from this PR locally following the plotly via window module instructions, I unfortunately can't find a way to do the same in the stackblitz example — it can't find the Plotly window global on an uploaded
plotly.jsfile.@plotly/plotly_js