You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@marthacryan should this be changed for 6.0 or left for after?
I guess this is technically changing an API, although as Alex said above, I think it's more of a bug than an API. I think it isn't a release blocker but might be slightly better to include in the release? I don't expect this would be very difficult to fix, but I think we might want to give some thought to what behavior we do want in this case. I expected it to be the same as just using the FigureWidget object without .show(), but we could also choose to add a warning / error or point the user to just calling fig instead of fig.show(). @ndrezn any opinions?
Activity
gvwilson commentedon Nov 11, 2024
@marthacryan should this be changed for 6.0 or left for after?
alexcjohnson commentedon Nov 11, 2024
Seems to me more like a bug than a feature
marthacryan commentedon Nov 12, 2024
@alexcjohnson Yes I would say it is likely a bug
marthacryan commentedon Nov 12, 2024
I guess this is technically changing an API, although as Alex said above, I think it's more of a bug than an API. I think it isn't a release blocker but might be slightly better to include in the release? I don't expect this would be very difficult to fix, but I think we might want to give some thought to what behavior we do want in this case. I expected it to be the same as just using the
FigureWidget
object without.show()
, but we could also choose to add a warning / error or point the user to just callingfig
instead offig.show()
. @ndrezn any opinions?ndrezn commentedon Nov 12, 2024
I agree that it's a bug but IMO it's not a release blocker. I don't think it's worth changing behaviour unless we're applying a fix.