fix: prevent duplicate item state from React 18 double render #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…render - Added guard logic in propUpdater to prevent duplicate items from being pushed to state. - Improved state initialization to handle React 18's double rendering in Strict Mode. - Added unit test to ensure duplicate state is not introduced on re-renders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a React 18-related issue where moving an item between Columns and Rows in the
PivotTableUIcauses duplicated state due to React 18's double rendering behavior in Strict Mode.Changes
handleDuplicates()utility to filter out duplicate items from state arrays.handleDuplicates()into thepropUpdater()method for rows and cols keys.