Skip to content

Conversation

@Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Aug 18, 2025

Why

A usage of the ambient THREE namespace snuck back in with #2511. The ambient THREE namespace was removed in @types/[email protected].

What

Removes usages of the ambient THREE namespace.

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Aug 18, 2025

@Methuselah96 is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 18, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Methuselah96
Copy link
Contributor Author

@abernier Friendly bump, should be an easy merge

@abernier
Copy link
Member

abernier commented Sep 11, 2025

@Methuselah96 why just Center? Shouldn't this apply more largely to all other drei's comps?

@abernier abernier merged commit 3b5d7dc into pmndrs:master Sep 11, 2025
3 of 4 checks passed
@Methuselah96
Copy link
Contributor Author

Methuselah96 commented Sep 11, 2025

In other components, there is a import * as THREE from 'three', but not in Center. An alternative fix would be to import THREE, but it seems like the convention in Center is to use named imports

@Methuselah96 Methuselah96 deleted the fix-center-three-reference branch September 11, 2025 16:35
@github-actions
Copy link

🎉 This PR is included in version 10.7.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants