Skip to content

fix(middleware): types and devtools #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2021
Merged

fix(middleware): types and devtools #613

merged 5 commits into from
Oct 26, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 26, 2021

close #609.

#601 broke typical usage of devtools. And, typing wasn't precise anyway. It's fixed.

There are some refactors too.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab94691:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@github-actions
Copy link

github-actions bot commented Oct 26, 2021

Size Change: +21 B (0%)

Total Size: 10.6 kB

Filename Size Change
dist/esm/middleware.js 2.51 kB +10 B (0%)
dist/middleware.js 2.73 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size
dist/context.js 622 B
dist/esm/context.js 521 B
dist/esm/index.js 1.2 kB
dist/esm/shallow.js 272 B
dist/esm/vanilla.js 520 B
dist/index.js 1.32 kB
dist/shallow.js 318 B
dist/vanilla.js 630 B

compressed-size-action

dai-shi added a commit that referenced this pull request Oct 26, 2021
dai-shi added a commit that referenced this pull request Oct 26, 2021
* fix(tests): immer middleware type test

* empty commit

* sync with #613
@dai-shi dai-shi merged commit ad318f3 into main Oct 26, 2021
@dai-shi dai-shi deleted the fix/types/middleware branch October 26, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

immer as middleware and use devtools typescript
1 participant