Undeprecate preview traits? #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Mar 19, 2025
Comment on lines
+26
to
+33
| private struct DependenciesPreviewModifier: PreviewModifier { | ||
| let updateValuesForPreview: @Sendable (inout DependencyValues) -> Void | ||
|
|
||
| func body(content: Content, context: ()) -> some View { | ||
| prepareDependencies(updateValuesForPreview) | ||
| return content | ||
| } | ||
| } |
There was a problem hiding this comment.
Introducing a preview modifier allows us to delay when dependencies are prepared to the computation of the preview's body.
mbrandonw
approved these changes
Mar 28, 2025
3 tasks
stephencelis
added a commit
that referenced
this pull request
May 8, 2025
While #353 resolved a big issue with using a preview trait to override dependencies, there are sadly other intermittent tooling issues that we have no control over. Preview traits are just too much of a black box for us to reliably hook into, so let's not steer folks the wrong direction.
stephencelis
added a commit
that referenced
this pull request
May 8, 2025
While #353 resolved a big issue with using a preview trait to override dependencies, there are sadly other intermittent tooling issues that we have no control over. Preview traits are just too much of a black box for us to reliably hook into, so let's not steer folks the wrong direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I stumbled onto a fix for preview code bleeding between previews, so this works in a single file:
The one caveat to this is that if you access a dependency directly in the
#Previewblock you must use@Previewable @Dependency, but that's the same for@Environment.