Skip to content

Add AppDelegate example in GRDBQueryKey's reportIssue comment #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

acosmicflamingo
Copy link
Contributor

Figure others may stumble upon the issue I found myself in when using GRDB in UIKit. Based off Stephen's suggestion in the Slack channel: https://pointfreecommunity.slack.com/archives/C04KQQ7NXHV/p1733690546509319?thread_ts=1733637497.493979&cid=C04KQQ7NXHV

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than make the reported issue any longer, what do you think of including a link to documentation that contains more information?

@acosmicflamingo
Copy link
Contributor Author

That sounds good! Where would the link go? Some documentation of swift-dependencies that I can create?

@stephencelis
Copy link
Member

I think the documentation of prepareDependencies is a good spot. Going to close the PR on this end for now, but thanks for bringing it up!

@acosmicflamingo
Copy link
Contributor Author

Sure! Right in the "important" block?
image

@stephencelis
Copy link
Member

@acosmicflamingo I don't think it needs to be in a callout block. It can just be an example of usage in SwiftUI vs. UIKit with code blocks.

@acosmicflamingo
Copy link
Contributor Author

I created two PRs that incorporate your suggestions:

I imagine this is the way you envisioned it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants