Fix scheduler weight and add test (#614)

- **Add test to collectives pallet**
- **Manually edit scheduler weight**

## Investigation

The Rust compiler changed how the `stringify!` macro formats paths on
[Aug 12th
'24](rust-lang/rust#128992 (comment)).
I assume that this broke the V1 benchmarking
[here](https://github.com/paritytech/polkadot-sdk/blob/7ecf3f757a5d6f622309cea7f788e8a547a5dce8/substrate/frame/benchmarking/src/v1.rs#L1011).
We had updated the scheduler pallet to V2 syntax (which is [not
affected](https://github.com/paritytech/polkadot-sdk/blob/df99fb9431a579589c1c87832222c9551b5c4f7c/substrate/frame/support/procedural/src/benchmark.rs#L565))
on [Nov 20th '24](paritytech/polkadot-sdk#6292).
We did not back-port this since there was no apparent reason for it.
The is why it seemingly fixed it self on SDK master but not in the
runtimes repo (since that is using V1 scheduler benchmarking).
Another indication for this is the fact that it did work on the
[whitelist
pallet](https://github.com/polkadot-fellows/runtimes/blob/6b85bf6adb427942976648e6d235e0169dfced16/relay/polkadot/src/weights/pallet_whitelist.rs#L85),
which is on V2 much longer but used the same [custom pov
mode](https://github.com/paritytech/polkadot-sdk/blob/b76e91acc953e682b3ddcfc45ecacaaf26c694a1/substrate/frame/whitelist/src/benchmarking.rs#L68).

Adding some sanity checks to prevent this in the future here
paritytech/polkadot-sdk#7785

- [ ] Does not require a CHANGELOG entry

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>

Author: ggwpez

CHANGELOG.md

@@ -4,6 +4,12 @@ Changelog for the runtimes governed by the Polkadot Fellowship.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## [Unreleased]
+
+### Fixed
+
+- Correct weights of the scheduler pallet to avoid failing fellowship proposals ([polkadot-fellows/runtimes#614](https://github.com/polkadot-fellows/runtimes/pull/614))
+
 ## [1.4.1] 26.02.2025
 
 ### Fixed

system-parachains/collectives/collectives-polkadot/src/lib.rs

@@ -1311,3 +1311,30 @@ fn test_transasction_byte_fee_is_one_twentieth_of_relay() {
 	let parachain_tbf = TransactionByteFee::get();
 	assert_eq!(relay_tbf / 20, parachain_tbf);
 }
+
+#[test]
+fn scheduler_weight_is_sane() {
+	use pallet_scheduler::WeightInfo;
+	type W = <Runtime as pallet_scheduler::Config>::WeightInfo;
+
+	fn lookup_weight(s: u32) -> Weight {
+		W::service_agendas_base() +
+			W::service_agenda_base(
+				<Runtime as pallet_scheduler::Config>::MaxScheduledPerBlock::get(),
+			) + W::service_task_base() +
+			W::service_task_fetched(s) +
+			W::service_task_named() +
+			W::service_task_periodic()
+	}
+
+	let limit = Perbill::from_percent(90) * MaximumSchedulerWeight::get();
+
+	let small_lookup = lookup_weight(128);
+	assert!(small_lookup.all_lte(limit), "Must be possible to submit a small lookup");
+
+	let medium_lookup = lookup_weight(1024);
+	assert!(medium_lookup.all_lte(limit), "Must be possible to submit a medium lookup");
+
+	let large_lookup = lookup_weight(1024 * 1024);
+	assert!(large_lookup.all_lte(limit), "Must be possible to submit a large lookup");
+}