Fix scheduler weight and add test #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Mar 3, 2025
system-parachains/collectives/collectives-polkadot/src/weights/pallet_scheduler.rs
Outdated
Show resolved
Hide resolved
…/pallet_scheduler.rs
bkchr
approved these changes
Mar 3, 2025
|
/cmd fmt |
|
Command "fmt" has started 🚀 See logs here |
|
Command "fmt" has finished ✅ See logs here |
xlc
approved these changes
Mar 3, 2025
ordian
approved these changes
Mar 4, 2025
kianenigma
approved these changes
Mar 4, 2025
acatangiu
approved these changes
Mar 4, 2025
bkontur
approved these changes
Mar 4, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/merge |
|
Enabled Available commands
For more information see the documentation |
lrazovic
added a commit
to Polimec/polimec-node
that referenced
this pull request
Mar 5, 2025
## What and Why? Added two new runtime API endpoints to the `UserInformation`: 1. `evaluations_of`: Retrieves all evaluations made by a user, with optional filtering by project id. 2. `participations_of`: Retrieves all bids made by a user, with optional filtering by project id. ## Also - Restored the old `pallet_scheduler` weights, as per polkadot-fellows/runtimes#614 - Bumped `UserInformation` API version from 1 to 2 to reflect these additions - Updated Rust toolchain from 1.81.0 to 1.84.1. So we use the same Rust version used by `srtool` (https://github.com/paritytech/srtool/releases/tag/v0.18.2) - Removed `--no-wasm-std` flag from `srtool` build commands
Merged
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
Release 1.4.2 for: - #535 (PAH and KAH) - #614 (P Collectives) - #604 (PAH and KAH) --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation
The Rust compiler changed how the
stringify!macro formats paths on Aug 12th '24. I assume that this broke the V1 benchmarking here. We had updated the scheduler pallet to V2 syntax (which is not affected) on Nov 20th '24. We did not back-port this since there was no apparent reason for it.The is why it seemingly fixed it self on SDK master but not in the runtimes repo (since that is using V1 scheduler benchmarking).
Another indication for this is the fact that it did work on the whitelist pallet, which is on V2 much longer but used the same custom pov mode.
Adding some sanity checks to prevent this in the future here paritytech/polkadot-sdk#7785