Fix captive dependency: make DasBlogSettings reactive to config changes#777
Merged
Conversation
DasBlogSettings previously snapshotted IOptionsMonitor.CurrentValue in its constructor, then was captured by singleton managers - freezing config for the app lifetime. Changes: - Store IOptionsMonitor<T> references and read .CurrentValue on each property access - Make URL properties (RssUrl, ShortCutIconUrl, etc.) computed so they reflect Root/Theme changes - Remove setters from IDasBlogSettings interface (no external callers) - Change IDasBlogSettings registration from Transient to Singleton - Remove manual config snapshot updates in AdminController (IOptionsMonitor with reloadOnChange:true handles this automatically)
Refactored DasBlog service registrations to use appropriate lifetimes (e.g., IDasBlogSettings as singleton instead of transient). Consolidated using statements. Added transient registrations for user and role stores, IPrincipal, and ISiteRepairer. These changes improve dependency injection setup and support user/role management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix captive dependency: make DasBlogSettings reactive to config changes
DasBlogSettings previously snapshotted IOptionsMonitor.CurrentValue in its constructor, then was captured by singleton managers - freezing config for the app lifetime.
Changes:
Store IOptionsMonitor references and read .CurrentValue on each property access
Make URL properties (RssUrl, ShortCutIconUrl, etc.) computed so they reflect Root/Theme changes
Remove setters from IDasBlogSettings interface (no external callers)
Change IDasBlogSettings registration from Transient to Singleton
Remove manual config snapshot updates in AdminController (IOptionsMonitor with reloadOnChange:true handles this automatically)