Removing redundant settings (Part 1)#782
Merged
Merged
Conversation
Clean up ISiteConfig, SiteConfig, SiteViewModel, and config files by removing unused properties for email notifications, URL formatting, Google Maps, OpenID, AMP pages, and other legacy options. This streamlines configuration and reduces code complexity.
Removed all code, config properties, and UI elements related to the XSS Upstream feature. This includes property removals from ISiteConfig, SiteConfig, SiteConfigTest, and SiteViewModel, as well as deletion of related XML elements in site.config and site.Development.config, and hidden fields in Settings.cshtml. The project no longer supports XSS Upstream integration.
All POP3-related properties and settings have been removed from ISiteConfig, its implementations, site configuration files, and the settings view. This deprecates support for POP3 email integration and related features throughout the application.
Eliminated all properties and config entries related to content filtering and external spam blocking services from site configuration, interfaces, view models, and views. This includes removal of settings for ApplyContentFiltersToWeb, ApplyContentFiltersToRSS, ContentFilters, EnableCoComment, EnableSpamBlockingService, and SpamBlockingServiceApiKey. The ISpamBlockingService property is now only retained as an ignored property.
Removed CrosspostSiteArray and PingServiceArray from ISiteConfig, SiteConfig, and SiteConfigTest. These array properties were used for XML serialization but are now replaced by collection properties, simplifying the interface and implementation.
Expanded site.config with Mastodon, CDN, reCAPTCHA, TinyMCE, and security settings. Added options for comment display, cookie consent, and SMTP sender. Removed deprecated options including Google Maps, OpenID, AMP, and some email notifications to modernize configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and deprecation of legacy configuration features.
PR Summary
This pull request removes obsolete configuration properties and features from the DasBlog site configuration system, while introducing new settings for modern integrations.