Fix FutureWarning for DataFrameGroupBy.grouper
#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machow
approved these changes
Feb 14, 2024
Collaborator
machow
left a comment
machow
left a comment
There was a problem hiding this comment.
Nice catch, thanks! It looks like this indices method has been around for a while, so should be okay to use!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a future warning displayed in the stub:
More details related to this warning can be found in the Pandas v2.2.0 release notes and issue GH 56521.
Instead of using
g_df.grouper.indices, it might be better to directly useg_df.indices. By usingg_df.indices, we shouldn't encounter any backward compatibility issues IMO.BTW, if we don't really need the values as a list type, directly returning
data.groupby(group_key).indicesmight be another option.