Skip to content

Ark: R call stack in debugger is off-by-one #5155

Closed
@lionel-

Description

@lionel-

If you click on foo() in the call stack, you end up on the call site of foo() rather than in the call frame of foo(). This makes for a confusing experience.

Instead of having <current> at the top, we could have <global> at the bottom, and then shift all calls by one.

In the following screencast, see how clicking on vars_select_eval() takes you to base::withCallingHandlers(). This is particularly confusing because the call site is the one that triggered chained evaluation of lazily evaluated arguments, so there is no visible relation to vars_select_eval(). If we shift by one, this frame will be called withCallingHandlers() which makes much more sense.

Screen.Recording.2024-10-24.at.17.31.06.mov

Metadata

Metadata

Assignees

Labels

area: debuggerIssues related to Debuggingarea: kernelsIssues related to Jupyter kernels and LSP serversbugSomething isn't workinglang: r

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions