Missing Logo from (Windows) installer

[kv9898]

System details:

WIndows 11

Positron and OS details:

Positron Version: 2025.04.0 (system setup) build 204
Code - OSS Version: 1.98.0
Commit: cfac68a
Date: 2025-03-27T03:39:59.107Z
Electron: 34.2.0
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Windows_NT x64 10.0.26100

Interpreter details:

R 4.4.3

Describe the issue:

Missing Positron logo from the installer. I'm not sure if this is a Windows only issue.

Steps to reproduce the issue:

1. Download the system installer for Windows
2. No logo is displayed

Expected or desired behavior:

The Positron logo appears.

[timtmok]

I think this might be a localization issue. I'm trying to reproduce by setting Windows to another display language.

[kv9898]

I think this might be a localization issue. I'm trying to reproduce by setting Windows to another display language.

The thing is the logo was displayed normally in previous versions (I did not change my language settings), have there been any changes to the installer?

[kv9898]

@timtmok FYI, 2025.04.0-173's logo is displayed normally for me

[timtmok]

Thank you for the extra info on the build. I think this might have regressed from merging VSCode 1.98.0. There was one change to the installer that looks like we didn't merge into Positron's installer. I don't think it would have affected this since it was removing some entries to the registry but I haven't looked at the other parts of generating the installer.

I definitely see it now in the build where 1.98.0 was merged and I don't think any of the other commits are related to the installer.

[timtmok]

The change that seems to stand out from the 1.98.0 merge is that innosetup updated (6.0.5->6.4.1). A lot of changes occurred in between these versions. I'm checking if there's any documentation of any changes that may have caused this. I may build this in the background with various versions to see if anything stands out.

[timtmok]

I've identified one difference to the upstream logos and it's the alpha channel. We have had the alpha channel on the bitmaps before the Inno Setup update so it might be a problem with the newer Inno Setup.

Setting WizardImageAlphaFormat=defined with the alpha channel doesn't seem to fix the problem. Removing the alpha channel from the bitmaps also did not fix the issue.

What did finally fix it was regenerating the images on Windows (this did not work on Mac). Git didn't seem to think there were differences between the Mac and Windows regenerated files so I'm not sure why the Windows versions worked.

I'm running a build on my branch now to confirm that it is fixed in a release build.