Assistant: remove duplicate model provider modal command

[sharon-wang]

System details:

Positron and OS details:

Positron Version: 2025.07.0 (Universal) build 65
Code - OSS Version: 1.100.0
Commit: 8be02b6
Date: 2025-06-06T03:33:25.176Z
Electron: 34.5.1
Chromium: 132.0.6834.210
Node.js: 20.19.0
V8: 13.2.152.41-electron.0
OS: Darwin arm64 24.5.0

Interpreter details:

n/a

Describe the issue:

Both of these commands go to the same modal dialog.

Steps to reproduce the issue:

1. Run the commands in the screenshot
2. Notice that both of them go to the same modal dialog

Expected or desired behavior:

Since these commands go to the same place, to avoid confusion about which one to pick, let's remove the positron-assistant.addModelConfiguration one and keep the positron-assistant.configureModels one, since the modal is for both adding and removing model providers.

We'll also need to update any related documentation on our website and wiki to reference the Positron Assistant: Configure Language Model Providers command instead of the Positron Assistant: Add Language Model Provider one.

Were there any error messages in the UI, Output panel, or Developer Tools console?

n/a

[sharon-wang]

Oh, I just saw this: #7950. @seeM is it expected that both commands appear? I don't have positron.assistant.newModelConfiguration defined.

[seeM]

Hm, it looks like the enablement part I added doesn't apply when the setting isn't defined, possibly because it's a "hidden" setting so it doesn't have a defined default.

EDIT: The intention was:

• When positron.assistant.newModelConfiguration is enabled (which is the default), only the "configure" command is available and goes directly to the new modal UI, since that lets you add/remove providers in one place.
• When positron.assistant.newModelConfiguration is disabled, both commands are available.
  • "Configure" opens a quick pick that lets you remove providers, and has an option to "add" which opens the old add UI.
  • "Add" goes directly to the old add UI.

EDIT2: We could also consider just removing the old modal and the quickpick. We'd need to double-check that no one is depending on that e.g. to test supported Vercel AI models that aren't enabled by default.

[sharon-wang]

Thank you!

It would be great to remove the old modal code, as it currently adds some complexity to the code and state of the Language Model Providers component, which has logic for both modals.

I'm checking on any remaining usage of the old modal + quickpick. So far, we'll want to wait until after #8030 is merged to remove the old modal. I'll wait on a bit more feedback on usage, then if all is well, I'll draft a PR to remove the modal.

[rodrigosf672]

Verified Fixed

Positron Version(s) : 2025.07.0 (Universal) build 170
OS Version          : macOS Sequoia 15.5

Test scenario(s)

• The provider modal opens via the command positron-assistant.configureModels and via the chat pane

• New command positron-assistant.logStoredModels yields output with chat and completion models user has authenticated with.

2025-06-23 10:34:40.018 [info] Stored Models: {
  "chatModels": [
    {
      "name": "Anthropic",
      "model": "claude-3-5-sonnet-latest",
      "provider": "anthropic"
    }
  ],
  "completionModels": "None"
}

As usual, thank you for the helpful QA Notes in the PR, @sharon-wang.