Skip to content

Assistant: Enable streaming inline edits by default #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Jun 18, 2025

I haven't encountered any issues with this enabled in my testing. Also haven't gotten any bug reports from testers.

Release Notes

New Features

  • Enabled streaming edits in Assistant inline editor chats by default.

Bug Fixes

  • N/A

@seeM seeM requested review from jmcphers and sharon-wang June 18, 2025 13:53
Copy link

github-actions bot commented Jun 18, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

sharon-wang
sharon-wang previously approved these changes Jun 18, 2025
Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, LGTM otherwise!

@@ -135,7 +135,7 @@
},
"positron.assistant.streamingEdits.enable": {
"type": "boolean",
"default": false,
"default": true,
"description": "%configuration.streamingEdits.enable%",
"tags": ["experimental"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is enabled by default, should it still be tagged with experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed in 8d97d4b.

jmcphers
jmcphers previously approved these changes Jun 19, 2025
@seeM seeM dismissed stale reviews from jmcphers and sharon-wang via 8d97d4b June 20, 2025 09:43
@seeM seeM merged commit 5b46d02 into main Jun 20, 2025
8 checks passed
@seeM seeM deleted the feature/enable-streaming-inline-edits branch June 20, 2025 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants