Skip to content

Improve keyboard navigation for Plots #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Jul 1, 2025

Quick change to support arrows to navigate the Plots history.

Addresses #8327.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

The arrow keys aren't scoped to the orientation of the filmstrip -- that is, "up" and "left" will take you to the previous plot, and "down" or "right" to the next one, regardless of whether the filmstrip is on the top or bottom.

tags: @:plots

@jmcphers jmcphers requested a review from timtmok July 1, 2025 19:48
Copy link

github-actions bot commented Jul 1, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:plots

readme  valid tags

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmcphers jmcphers merged commit 59d6fb0 into main Jul 2, 2025
11 checks passed
@jmcphers jmcphers deleted the feature/plot-nav-arrows branch July 2, 2025 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants