Calculate cell width of multi-line cells correctly#91
Conversation
Ensures that the optimal cell width is calculated correctly when the column's content contains more than one line. Fixes #49
| def styled_width_of(text) | ||
| options = @text_options.reject { |k| k == :style } | ||
| with_font { @pdf.width_of(text, options) } | ||
| if text.empty? |
Member
There was a problem hiding this comment.
Doesn't this case get properly handled by width_of?
Author
There was a problem hiding this comment.
You are correct, width_of handles it correctly, but line 142 would subsequently call #max on an empty array and return nil; thus the conditional.
Member
There was a problem hiding this comment.
I personally would've preferred .max || 0 but it's not critical.
Is this case covered by a spec?
Author
There was a problem hiding this comment.
Yeah, I think .max || 0 is probably more readable. I'll change that and add a spec.
Member
|
I'll take closer look a bit later. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the optimal cell width is calculated correctly when its content has more than one line.
This is similar to #50 but with specs.
Fixes #49.