Improve min_width calculation using longest word#98
Open
ashtonthomas wants to merge 1 commit intoprawnpdf:masterfrom
Open
Improve min_width calculation using longest word#98ashtonthomas wants to merge 1 commit intoprawnpdf:masterfrom
ashtonthomas wants to merge 1 commit intoprawnpdf:masterfrom
Conversation
Instead of using the styled length of 'M', use the styled width of the longest word in order to calculate the min_width of a Cell's Text. This will prevent words from being split in the middle. There may be an issue with this if the total of the min_widths add up to more than the available width. We should look into the tests around that to see if something will error or if this is being accounted for already.
Author
|
A We might want to go with @ericfreese's suggestion of using a :word_wrap option can be set. If this option is set (to something like Just a thought.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am having the same issue as #67
This pull request is an alternative to #68 (just go ahead and use min width of longest word as @ericfreese suggests)
Instead of using the styled length of 'M', use the styled width of the longest word in order to calculate the min_width of a Cell's Text.
This will prevent words from being split in the middle.
There may be an issue with this if the total of the min_widths add up to more than the available width. We should look into the tests around that to see if something will error or if this is being accounted for already.